feat: add version field to ExecutionContext#6052
Merged
alamb merged 3 commits intoApr 24, 2023
Merged
Conversation
alamb
reviewed
Apr 20, 2023
|
|
||
| /// The shared state of all [`Task`] created from the same [`PipelinePlan`] | ||
| #[derive(Debug)] | ||
| #[allow(dead_code)] |
Contributor
There was a problem hiding this comment.
What do you think about adding a function like
pub fn version(&self) -> &str {
...
}Which would avoid the need for allow(dead_code) perhaps
Member
Author
I vote for |
Weijun-H
force-pushed
the
add-version-field-to-ExecutionContext
branch
from
f8d81a0 to
8b2154d
Compare
alamb
reviewed
Apr 21, 2023
|
|
||
| /// Return version | ||
| pub fn version(&self) -> &str { | ||
| &self.version |
Contributor
There was a problem hiding this comment.
I think you could just call env!("CARGO_PKG_VERSION") here -- is there any reason to create a string to do so?
Suggested change
| &self.version | |
| env!("CARGO_PKG_VERSION") |
alamb
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1517
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?